Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Falcon signature tests. #1257

Merged
merged 197 commits into from
Apr 11, 2024

Conversation

scottdieringer
Copy link
Contributor

@scottdieringer scottdieringer commented Feb 26, 2024

Describe your changes

Addresses 1096 - Adding Falcon signature tests.

Adds following tests:

  • norm_sq procedure, both overflow and underflow.
  • diff_mod_q procedure.
  • powers_of_tau procedure.
  • probabilistic product routine from the load_h_s2_and_productprocedure to the probabilistic_productprocedure. Both success and failure cases.
  • adv.push_sig.rpo_falcon512 procedure. Both success and failure cases.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth and others added 30 commits October 11, 2023 21:06
The sentence describing the column $k_0$ had its order reversed, and the
table headers were incorrectly named as $x_i$ and $y_i$ instead of $a_i$
and $b_i$ as described in the introduction.
…std-asm-utils

Introduce `std::utils` assembly module
… info

This commit changes the `import_info` fields of ProgramAst and ModuleAst
to remove the `Option` wrapper, since it does not appear to serve a
specific purpose, and both complicates access to the imports, and
requires redundant code in a few places to access common information
from the imports. It also required fallible checks in a few places where
empty module import info would be suitable as a fallback.

After this change, one can access the ModuleImports struct directly on
both ProgramAst and ModuleAst via the `import_info` function, which
returns a reference to the field. Redundant functions in both structs
were removed if they are already provided by ModuleImports.
…c-fix

docs(mdbook): minor change in the bitwise chiplet
…and-debug

Expand capabilities of the `debug` instruction
…host-event-handler

Add `emit` instruction and host event handler
* ContextId type

* propagate MemoryContextId

* fix tests

* MemoryContextId -> ContextId

* move definition

* Remove derive-more dependency

* fix repl

* fmt

* docstring

* import newline

* Remove `Sub` from `ContextId`

* blank line

* section name change

* blank line

* use `ContextId::root()`

* fmt

* memory context -> execution context
@scottdieringer
Copy link
Contributor Author

@scottdieringer - thank you! Could you rebase this from the latest next? Should fix all the merge conflicts.

Up to date with next and merge conflicts gone.

Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @scottdieringer !

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth March 5, 2024 15:34
@scottdieringer
Copy link
Contributor Author

Ready for review.

@scottdieringer
Copy link
Contributor Author

@bobbinth Merged the latest from miden-crypto 0.9.0 into this PR. Ready for review.

@bobbinth
Copy link
Contributor

bobbinth commented Apr 4, 2024

@scottdieringer thank you! Will review today - sorry for all the delays!

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! (and sorry again for all the delays). I left a few comments inline - but nothing major.

.gitignore Outdated Show resolved Hide resolved
stdlib/Cargo.toml Outdated Show resolved Hide resolved
miden/tests/integration/operations/decorators/advice.rs Outdated Show resolved Hide resolved
miden/tests/integration/operations/decorators/advice.rs Outdated Show resolved Hide resolved
miden/tests/integration/operations/decorators/advice.rs Outdated Show resolved Hide resolved
miden/tests/integration/operations/decorators/advice.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @scottdieringer for doing this

@scottdieringer
Copy link
Contributor Author

@bobbinth Addressed PR comments, ready for review.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one tiny nit inline - but we can merge even without it.

stdlib/Cargo.toml Outdated Show resolved Hide resolved
@bobbinth bobbinth merged commit d9dc097 into 0xPolygonMiden:next Apr 11, 2024
15 checks passed
@scottdieringer scottdieringer deleted the falcon-sig-tests branch April 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.